-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add files via upload #292
Add files via upload #292
Conversation
Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process. Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment. |
Thanks for this submission. Sorry for the delay in review. The version number needs to be changed in the .kps file (Keyman package source). It should be set to 1.2 (to match what you have in the HISTORY.md file. This is what a new build that gets offered to users. I'd also suggest changing the "Laz Dictionary 1.2 generated from template." line in the .model.ts file to just "Laz Dictionary". It's just a comment, but if you include the version number then it needs to be updated (or risk confusing someone) for each new version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I made the changes!
I'm a little bit inexperienced when it comes to Github, so I'm not sure how to replace files! I just amended the code instead. |
Thanks for persevering! |
Ready for review.