Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #292

Merged
merged 6 commits into from
Dec 3, 2024
Merged

Add files via upload #292

merged 6 commits into from
Dec 3, 2024

Conversation

okandale
Copy link
Contributor

Ready for review.

@keyman-server
Copy link

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

@DavidLRowe
Copy link
Contributor

Thanks for this submission. Sorry for the delay in review.

The version number needs to be changed in the .kps file (Keyman package source). It should be set to 1.2 (to match what you have in the HISTORY.md file. This is what a new build that gets offered to users.

I'd also suggest changing the "Laz Dictionary 1.2 generated from template." line in the .model.ts file to just "Laz Dictionary". It's just a comment, but if you include the version number then it needs to be updated (or risk confusing someone) for each new version.

Copy link
Contributor Author

@okandale okandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I made the changes!

@DavidLRowe
Copy link
Contributor

The .kps file still has:
<Version URL="">1.1</Version>

If you're using Keyman Developer, select the .kps file, Details tab, and update the version number:
image

@okandale
Copy link
Contributor Author

okandale commented Dec 3, 2024

I'm a little bit inexperienced when it comes to Github, so I'm not sure how to replace files! I just amended the code instead.

@DavidLRowe DavidLRowe merged commit 6f1b752 into keymanapp:master Dec 3, 2024
2 checks passed
@DavidLRowe
Copy link
Contributor

Thanks for persevering!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants