Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: commit singer files to store #11

Merged
merged 8 commits into from
Sep 28, 2023
Merged

feat: commit singer files to store #11

merged 8 commits into from
Sep 28, 2023

Conversation

kgpayne
Copy link
Owner

@kgpayne kgpayne commented Sep 21, 2023

  • wip
  • encapsulate singer file with metadata

@kgpayne
Copy link
Owner Author

kgpayne commented Sep 22, 2023 •
edited
Loading

Todo:

  • source partitions from path manager
  • implement post-processor on path manager to simplify the conversion from GenericPath to pathlib.Path
  • update manifest on commit

@kgpayne
Copy link
Owner Author

kgpayne commented Sep 28, 2023

Manifest handling is a pretty huge chunk of work. Going to punt to a future issue/pr.

@kgpayne kgpayne marked this pull request as ready for review September 28, 2023 16:13
@kgpayne kgpayne merged commit a6f741e into main Sep 28, 2023
5 checks passed
@kgpayne kgpayne deleted the kgpayne/commit-singer-files-to-store branch September 28, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kgpayne