Improved modal example 1 #238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hydra
force-pushed
the
improved-modal-example-1
branch
from
b985bab to
35827c3
Compare
|
Added an example, in Screen.Recording.2025-01-10.185420.mp4 |
This was referenced Jan 13, 2025
Dialog button callbacks now return a ShouldClose and are FnMut instead of FnOnce. This allows nested dialogs to be invoked through the buttons on a dialog in addition to the content of the dialog itself. While doing this, I realized the documentation for ModalHandle::build_dialog claimed it was used to create nested dialogs, but it wasn't actually implemented that way. In trying to make the modal.rs expanded example work, I wanted both behaviors -- updating the current handle contents with a new dialog and creating a nested dialog, so there is now a `ModalHandle::build_nested_dialog` function in addition to the existing function.
…esents a more real-world use-case.
hydra
force-pushed
the
improved-modal-example-1
branch
from
48509a9 to
59c6d0e
Compare
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First cut of an improved example, based on discussions here:
https://discord.com/channels/578968877866811403/842093272540643339/1327300473174102036
Video of
modal-nested.rsScreen.Recording.2025-01-13.105351.mp4
Status: Ready for review.