Adjust croner integration to 6.x. Add version in README.md.

[Hexagon]

• Adjusts croner integration to croner 6.x
• Pin npm install command in readme to 6.x
• Fixes some tests that should not have succeded, but did on croner 5.x

Fixes #167

[Hexagon]

Updated for [email protected]

[kibertoad]

@Hexagon Is it necessary to have an async function here? Wouldn't it suffice to do return Promise.resolve().then(() => this.task.execute())?

[Hexagon]

@kibertoad Main reason for the async/await is that croner awaits the call internally, to make .isBusy() of the returned job work. Not too familiar with "raw" promises, guess you know better than me what should be used here 👀

() => return this.task.execute() might pass the promise further, allowing the croner await to work?

[kibertoad]

since you are awaiting it anyway, doing so here makes little sense.
mixing async functions and callbacks can be error-prone, so I would avoid introducing async function without a good reason.
() => return this.task.execute() might pass the promise further, allowing the croner await to work?
if croner does not necessarily expect a fully formed promise there (e. g. does not attach .then or .catch handlers to it), that should be sufficient, as await will work with both synchronous and asynchronous tasks, yes

[Hexagon]

👍 Will give that a try

[Hexagon]

Hmm, the overrun-test (allows preventing CronJob execution overrun with async tasks) only pass using async/await

[kibertoad]

what error are you getting?

[Hexagon]

The overrun protection does not work, the function is triggered again after 4000ms even though it should be blocking for 5000ms (pattern */2 * * ..)

This is how croner is expected to handle it https://github.com/Hexagon/croner/blob/master/docs/EXAMPLES.md#overrun-protection

... and the overrun protection works by setting blocked = x before and after calling the function, and awaiting the function

https://github.com/Hexagon/croner/blob/9a66976992a571074c9f508e02f9746649dd5a67/src/croner.js#L421

[kibertoad]

Looks like you are depending on it being a function then.
So I would suggest going the Promise.resolve route then

[Hexagon]

I can't seem to get this test working, can you have a look?

[kibertoad]

sure, I'll check it out tomorrow

[kibertoad]

I haven't forgotten about it, and looked into it in several different occassions, but I haven't figured out what exactly goes wrong there. Will give it another short in the nearby future

[KillerJulian]

@kibertoad any update?