[DO NOT MERGE] NO-ISSUE: Renamed SWF VS Code extension to Openshift Serverless Logic Editor and added update-version-to option to maven build #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulovmr
requested review from
mareknovotny,
krisv,
caponetto,
ricardozanini,
domhanak,
fantonangeli and
rgdoliveira
paulovmr
commented
May 15, 2024
| @@ -1,7 +1,6 @@ | |||
| ## Kogito Serverless Workflow Editor | |||
| ## Openshift Serverless Logic Editor | |||
There was a problem hiding this comment.
@ricardozanini @domhanak Let me know if you want any changes on the extension readme. This goes on the extension page in the marketplace.
caponetto
reviewed
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE as the scope of this PR is still being discussed and validated.
This PR includes the renamed Openshift Serverless Logic Editor VS Code extension to the maven build.
To execute the maven build, it is optional to export a custom NPM registry URL for dependencies download, like:
export NPM_REGISTRY_URL=https://registry.npmjs.orgWhen doing a release build, it is necessary to pass the version of the NPM packages as a property. It has to follow the
x.y.zpattern [1] [2]. I've added an automation for that in the maven build, so it can just be executed like this:mvn clean install -DpackagesVersion=1.33.0[1] https://docs.npmjs.com/about-semantic-versioning
[2] https://docs.npmjs.com/creating-a-package-json-file
To do: