Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

truncate table columns via css #507

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

robertkleinschuster
Copy link
Contributor

@robertkleinschuster robertkleinschuster commented Dec 11, 2024

What's new?

N/A

What's changed?

What's fixed?

N/A

Any other comments?

N/A

  • I am the original author of this code and I am giving it freely to the community and Pinchflat project maintainers

@kieraneglin
Copy link
Owner

Thank you for these PRs! I'll review and test them out tomorrow 🤙

@kieraneglin
Copy link
Owner

This is great! I'm happy with this as-is, but I was wondering if you'd be game to remove the other uses of the truncate method. It's mostly small things like Results for "{StringUtils.truncate(@search_term, 50)}" on the search page or Editing "{StringUtils.truncate(@media_item.title, 35)}" on the media item edit page. I think it'd be ideal if we could get to the point where the StringUtils.truncate method was removed entirely

@robertkleinschuster
Copy link
Contributor Author

This is great! I'm happy with this as-is, but I was wondering if you'd be game to remove the other uses of the truncate method. It's mostly small things like Results for "{StringUtils.truncate(@search_term, 50)}" on the search page or Editing "{StringUtils.truncate(@media_item.title, 35)}" on the media item edit page. I think it'd be ideal if we could get to the point where the StringUtils.truncate method was removed entirely

Yes, was planning on doing this already. I am a believer in small incremental change, small PRs. I knew the tables were straightforward but the other places i have to look into closley to not disrupt the layout.

@kieraneglin
Copy link
Owner

kieraneglin commented Dec 13, 2024

Fair enough! I'll merge this as-is and we'll go from there 🤙. FWIW, I think those additional changes would close #458

Thanks again!

@kieraneglin kieraneglin merged commit 01c9afa into kieraneglin:master Dec 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Truncate media items, sources, jobs via css
2 participants