observing empty buffer to handle replay on network lost

kinescope · Jun 24, 2024 · 0dfbb08 · 0dfbb08
1 parent a0d1fc5
commit 0dfbb08
Show file tree

Hide file tree

Showing 5 changed files with 63 additions and 1 deletion.
diff --git a/Sources/KinescopeSDK/Bags/KVO/KVOSubKey.swift b/Sources/KinescopeSDK/Bags/KVO/KVOSubKey.swift
@@ -10,6 +10,7 @@ import Foundation
 enum KVOSubKey {
     case playerStatus
     case playerItem
+    case playerItemBufferEmpty
     case playerItemStatus
     case playerTimeControlStatus
 }
diff --git a/Sources/KinescopeSDK/Bags/Notification/NotificationSubKey.swift b/Sources/KinescopeSDK/Bags/Notification/NotificationSubKey.swift
@@ -15,6 +15,7 @@ enum NotificationSubKey {
     case appDidEnterBackground
     case deviceOrientationChanged
     case itemDidPlayToEnd
+    case itemFailedToPlayToEndTime
 
     var notificationName: NSNotification.Name {
         switch self {
@@ -26,6 +27,8 @@ enum NotificationSubKey {
             return UIDevice.orientationDidChangeNotification
         case .itemDidPlayToEnd:
             return AVPlayerItem.didPlayToEndTimeNotification
+        case .itemFailedToPlayToEndTime:
+            return AVPlayerItem.failedToPlayToEndTimeNotification
         }
     }
 

diff --git a/Sources/KinescopeSDK/Player/KinescopeVideoPlayer.swift b/Sources/KinescopeSDK/Player/KinescopeVideoPlayer.swift
@@ -326,12 +326,19 @@ private extension KinescopeVideoPlayer {
         let observerFactory = CurrentItemObserver(playerBody: self, currentItemChanged: {
             [weak self] item in
             self?.kvoBag.removeObserver(for: .playerItemStatus)
+            self?.kvoBag.removeObserver(for: .playerItemBufferEmpty)
             if let item {
                 self?.addPlayerItemStatusObserver()
+                self?.addPlayerItemBufferIsEmptyObserver()
             }
         })
         kvoBag.addObserver(for: .playerItem, using: .init(wrappedFactory: observerFactory))
     }
+
+    func addPlayerItemBufferIsEmptyObserver() {
+        let observerFactory = EmptyBufferObserver(playerBody: self, repeater: $playRepeater)
+        kvoBag.addObserver(for: .playerItemBufferEmpty, using: .init(wrappedFactory: observerFactory))
+    }
 
     func addPlayerItemStatusObserver() {
         let observerFactory = CurrentItemStatusObserver(playerBody: self, 
@@ -368,6 +375,8 @@ private extension KinescopeVideoPlayer {
                                      using: .init(selector: #selector(changeOrientation)))
         notificationsBag.addObserver(for: .itemDidPlayToEnd,
                                      using: .init(selector: #selector(itemDidPlayToEnd)))
+        notificationsBag.addObserver(for: .itemFailedToPlayToEndTime,
+                                     using: .init(selector: #selector(itemFailedToPlayeToEndTime)))
     }
 
     func configureAnalytic() {
@@ -435,6 +444,11 @@ private extension KinescopeVideoPlayer {
         analytic?.send(event: .end)
     }
 
+    @objc func itemFailedToPlayeToEndTime(_ notification: Notification) {
+        let error = notification.userInfo?[AVPlayerItemFailedToPlayToEndTimeErrorKey] as? Error
+        Kinescope.shared.logger?.log(error: error, level: KinescopeLoggerLevel.player)
+    }
+
     func restoreView() {
         view?.showOverlay(isOverlayed)
         isPlaying ? play() : pause()

diff --git a/Sources/KinescopeSDK/Player/Observers/EmptyBufferObserver.swift b/Sources/KinescopeSDK/Player/Observers/EmptyBufferObserver.swift
@@ -0,0 +1,41 @@
+//
+//  EmptyBufferObserver.swift
+//  KinescopeSDK
+//
+//  Created by Nikita Korobeinikov on 24.06.2024.
+//
+
+import Foundation
+import AVFoundation
+
+final class EmptyBufferObserver: KVOObserverFactory {
+
+    private weak var playerBody: KinescopePlayerBody?
+    private weak var repeater: Repeater?
+
+    init(playerBody: KinescopePlayerBody,
+         repeater: Repeater) {
+        self.repeater = repeater
+        self.playerBody = playerBody
+    }
+
+    func provide() -> NSKeyValueObservation? {
+        playerBody?.strategy.player.currentItem?.observe(
+            \.isPlaybackBufferEmpty,
+            options: [.new, .old],
+            changeHandler: { [weak self] item, value in
+                let isBufferEmpty = value.newValue ?? item.isPlaybackBufferEmpty
+                if isBufferEmpty {
+                    self?.repeater?.start()
+                }
+
+                Kinescope.shared.logger?.log(
+                    message: "AVPlayer.isPlaybackBufferEmpty – \(isBufferEmpty)",
+                    level: KinescopeLoggerLevel.player
+                )
+            }
+        )
+    }
+
+}
+
diff --git a/Sources/KinescopeSDK/View/Player/KinescopePlayerView.swift b/Sources/KinescopeSDK/View/Player/KinescopePlayerView.swift
@@ -86,8 +86,11 @@ public class KinescopePlayerView: UIView {
             overlay?.isHidden = false
             overlay?.set(playing: true)
             progressView.showVideoProgress(isLoading: false)
-        case .paused, .waitingToPlayAtSpecifiedRate:
+        case .paused:
             overlay?.set(playing: false)
+        case .waitingToPlayAtSpecifiedRate:
+            overlay?.set(playing: false)
+            progressView.showVideoProgress(isLoading: true)
         @unknown default:
             break
         }