Speed up process template page #6377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BartChris
force-pushed
the
speed_up_template_list
branch
from
60c2ca7 to
42e89eb
Compare
BartChris
commented
Feb 3, 2025
| @@ -46,7 +49,7 @@ | |||
| import org.kitodo.production.workflow.model.Converter; | |||
|
|
|||
| @Named("TemplateForm") | |||
| @SessionScoped | |||
| @ViewScoped | |||
There was a problem hiding this comment.
Switch to ViewScoped to ensure that changes to templates are reflected in the process template list.
henning-gerhardt
suggested changes
Feb 6, 2025
Kitodo/src/main/java/org/kitodo/production/forms/TemplateForm.java
Outdated
Show resolved
Hide resolved
Kitodo/src/main/java/org/kitodo/production/forms/TemplateForm.java
Outdated
Show resolved
Hide resolved
henning-gerhardt
approved these changes
Feb 6, 2025
|
Maybe this changes should be applied for the 3.8.x branch too as this change is a good speed improvement. |
|
Backport: #6401 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5336
Using a custom HQL-query should speed up the retrieval of the process templates significantly. We only have to compute the template usage once and reuse it in the view.