-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump @testing-library/jest-dom from 6.1.3 to 6.6.3 #4608
base: master
Are you sure you want to change the base?
chore: bump @testing-library/jest-dom from 6.1.3 to 6.6.3 #4608
Conversation
The following labels could not be found: |
Deploying orbit with
|
Latest commit: |
2d5b134
|
Status: | ✅ Deploy successful! |
Preview URL: | https://3acdf950.orbit.pages.dev |
Branch Preview URL: | https://dependabot-npm-and-yarn-test-zz66.orbit.pages.dev |
Storybook staging is available at https://kiwicom-orbit-dependabot-npm-and-yarn-testing-library-jest-dom-6-6-3.surge.sh Playroom staging is available at https://kiwicom-orbit-dependabot-npm-and-yarn-testing-library-jest-dom-6-6-3.surge.sh/playroom |
Size Change: -2 B (0%) Total Size: 461 kB
ℹ️ View Unchanged
|
d8e455a
to
3edd305
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Key Issues
Removing the React.isValidElement(actions)
check could lead to runtime errors by attempting to render non-React elements, potentially causing application crashes.
3edd305
to
a5da586
Compare
a5da586
to
df1ab00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Key Issues
The removal of the type check for icon
could lead to runtime errors by allowing non-string types to be passed to the getIcon
function, which expects a string or null.
df1ab00
to
d6c06f2
Compare
d6c06f2
to
60e75ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Key Issues
The conditional type allows arrowLeftAriaLabel
and arrowRightAriaLabel
to be incorrectly provided when arrows
is false
, potentially leading to accessibility issues. The focus management code does not check for empty arrays, risking runtime errors.
60e75ba
to
8b49316
Compare
Deploying orbit with
|
Latest commit: |
60e75ba
|
Status: | ✅ Deploy successful! |
Preview URL: | https://5b7935df.orbit.pages.dev |
Branch Preview URL: | https://dependabot-npm-and-yarn-test-zz66.orbit.pages.dev |
Deploying orbit with
|
Latest commit: |
8b49316
|
Status: | ✅ Deploy successful! |
Preview URL: | https://48ff4495.orbit.pages.dev |
Branch Preview URL: | https://dependabot-npm-and-yarn-test-zz66.orbit.pages.dev |
8b49316
to
0655e88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Key Issues
Inconsistent event propagation in the Slide component could lead to unexpected behavior and bugs in parent components. Hardcoding the country name in CountryFlag bypasses existing logic, risking inconsistencies. Removing overflow handling may cause incorrect event propagation when content is scrollable.
Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from 6.1.3 to 6.6.3. - [Release notes](https://github.com/testing-library/jest-dom/releases) - [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md) - [Commits](testing-library/jest-dom@v6.1.3...v6.6.3) --- updated-dependencies: - dependency-name: "@testing-library/jest-dom" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
0655e88
to
2d5b134
Compare
Bumps @testing-library/jest-dom from 6.1.3 to 6.6.3.
Release notes
Sourced from
@testing-library/jest-dom
's releases.... (truncated)
Commits
5ba0156
fix: add vitest import when extending vitest matchers (#646)4468378
fix: remove recursive type reference in vitest types (#636)abba961
docs: add billyjanitsch as a contributor for bug (#644)9490615
docs: add G-Rath as a contributor for code (#643)ced792e
fix: fix lodash import in to-have-selection.js (#642)9b14804
feat: implement toHaveSelection (#637)f5b0e94
docs: add diegohaz as a contributor for ideas (#640)68e927e
docs: add pwolaq as a contributor for code, and test (#639)04005db
docs: add silviuaavram as a contributor for code, and test (#638)4723de3
docs: add mibcadet as a contributor for doc (#628)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)✨
Description by Callstackai
This PR updates the version of
@testing-library/jest-dom
from 6.1.3 to 6.6.3 in thepackage.json
file.Diagrams of code changes
Files Changed
@testing-library/jest-dom
to 6.6.3.This PR includes files in programming languages that we currently do not support. We have not reviewed files with the extensions
.json
. See list of supported languages.