feat: add ec_mul #886
Draft
feat: add ec_mul #886
+1,218
−567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #886 +/- ##
==========================================
- Coverage 78.10% 77.75% -0.35%
==========================================
Files 63 63
Lines 16700 16789 +89
==========================================
+ Hits 13043 13055 +12
- Misses 3657 3734 +77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
obatirou
reviewed
Mar 3, 2025
obatirou
reviewed
Mar 3, 2025
obatirou
reviewed
Mar 3, 2025
| // Assert is_on_curve_q_low is a boolean flag | ||
| assert is_on_curve_q_low * (1 - is_on_curve_q_low) = 0; | ||
| // Assert is_on_curve_q_high is a boolean flag | ||
| assert is_on_curve_q_high * (1 - is_on_curve_q_high) = 0; | ||
| // Assert g is on curve |
There was a problem hiding this comment.
Suggested change
| // Assert g is on curve | |
| // Assert p is on curve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #853
Closes #854
Closes #178