Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for an AWS illegal character issue upon certificate upload #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

magneticrob
Copy link

@magneticrob magneticrob commented Nov 28, 2024

An example cert_info value could be this:

[
["User ID", "USERIDGOESHERE"],
["Common Name", "Apple Development: Robert Baker (CERTIDGOESHERE)"],
["Organisation Unit", "ORG UNIT GOES HERE"],
["Organisation", "ORG NAME GOES HERE."],
["Country", "COUNTRY CODE"],
["Start Datetime", "2024-11-28 16:51:51 UTC"],
["End Datetime", "2025-11-28 16:51:50 UTC"]
]

"Common Name" in this case has parentheses, and was failing at this step as AWS rejected it with this error:

[16:28:39]: Request rejected by the downstream tagging service. Please check that you're only using allowed characters.

According to the docs: https://docs.aws.amazon.com/aws-cost-management/latest/APIReference/API_TagResource.html

Keys and values can only contain alphanumeric characters, spaces, and any of the following: _.:/=+@-

This change cleanses this input

…f a certificate could contain illegal characters
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Rob Baker seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants