[WIP] Staging branch for IAF work #225
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-masseau
commented
Feb 21, 2025
| @@ -95,6 +95,9 @@ object KlaviyoConfig : Config { | |||
|
|
|||
| override var baseUrl: String = BuildConfig.KLAVIYO_SERVER_URL | |||
| private set | |||
|
|
|||
| override var baseCdnUrl: String = BuildConfig.KLAVIYO_CDN_URL | |||
There was a problem hiding this comment.
TODO: add to config builder to test app can set it.
* Initial messaging module with webview dependency * Revert "Remove sample app from the repo, we'll just revert this commit to continue work on it later. (#46)" This reverts commit da1be69. * catch sample app up * Migrate sample to refreshVersions * Simple update to the sample code * Basic ability to add a webview to a provided Activity * Can't use this till google services file is added! * Implemented javascript bridge using newer android webview APIs and fallback older methods. Added bridge JS file that facilitates communication between webview/native, including detecting when all image tags have finished loading. * readability * commenting and cleanup * Native close button * Buncha progress on sample app * Add an actual view for interactivity * Inject Klaviyo Forms and Hook into Requests * making webview visible * deleting sample app (adding to test app) * pr comments * trying to remove code I think was only relevant for sample app * remove user agent string from webview * making user agent property public in DeviceProperties --------- Co-authored-by: Evan Masseau <> Co-authored-by: kennyklaviyo <[email protected]>
* creating new request and logging response * adding log before request enqueues
This reverts commit f0bcf9b.
…ode (#207) * removing unused bridge code and updating for local development * Commit TODOs * thx evan --------- Co-authored-by: Evan C Masseau <[email protected]>
* [CHNL-16653] Enqueue Profile Events * add exception to the mapper function run * pr comments
* support for aggregate events endpoint * support mapping and unit test * pr comments
* support mapping and unit test * supporting deeplinks and weak activity ref in the webview * pr comments
* Inject native bridge handshake data * Use string substitution for klaviyo.js script tag. Move base URL of klaviyo.js to a config (paves the way for test app to be able to set it) * Implement a basic abort event whynot * Not a test anymore :D --------- Co-authored-by: Evan Masseau <>
* handshake * fix test
* single webview * weak reference usage
evan-masseau
force-pushed
the
feat/iaf
branch
from
3ccae4d to
85db28e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature branch for IAF work
Check List
Changelog / Code Overview
Test Plan
Related Issues/Tickets