IAF - Initialize webview content with file URL #227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we'd used
loadDataWithBaseURL
to load in our HTML template as a string and explicitly state that the "base url" of the page is klaviyo.com. It appears that this is giving us CORS errors when loading fonts from another source however.Another option is
loadData
, but that appears to be limited to only loading otherdata
resources.The final option is
loadUrl
with afile://
path, which is what I'm experimenting with here. This is analogous to what the iOS SDK is doing also, and our font sheets were loading out of the box when tested there.If this fails to load fonts reliably, I'll go back to
loadDataWithBaseURL
and investigate intercepting and modifying request headers instead.Check List
Changelog / Code Overview
Test Plan
Related Issues/Tickets