Rewind array after foreach by reference in DataCollectionTest #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HHVM's behaviour on foreach by reference might differ from php. This is happening here. HHVM will incremend the internal array pointer while php doesn't. This causes test to fail on hhvm See https://github.com/facebook/hhvm/blob/master/hphp/doc/inconsistencies#L29-L35 This increases klein on HHVM from 97.66% to 100% o/
|
At least for the commit http://hhvm.com/frameworks/ tests against. |
|
Thank you so much for this PR! Merging this right away! |
Rican7
added a commit
that referenced
this pull request
Nov 24, 2014
Rewind array after foreach by reference in DataCollectionTest Thanks to @SiebelsTim we should now have 100% test compatibility with HHVM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HHVM's behaviour on foreach by reference might differ from php. This is happening here.
HHVM will incremend the internal array pointer while php doesn't. This causes test to fail on hhvm
See https://github.com/facebook/hhvm/blob/master/hphp/doc/inconsistencies#L29-L35
This increases klein on HHVM from 97.66% to 100% o/