Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'emscripten' property to versions.json #60

Merged
merged 2 commits into from
Dec 23, 2023

Conversation

lovell
Copy link
Contributor

@lovell lovell commented Dec 23, 2023

Emscripten does not guarantee ABI stability between versions so this information is useful for downstream consumers to verify compatibility.

Relates to lovell/sharp#3907 e.g. allows future possible automation of this.

(Use of xargs is to clean up the version number as it might be wrapped in quotes.)

lovell and others added 2 commits December 23, 2023 09:31
Emscripten does not guarantee ABI stability between versions so
this is useful for downstream consumers to verify compatibility.
Copy link
Owner

@kleisauke kleisauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kleisauke kleisauke merged commit b2e0f03 into kleisauke:master Dec 23, 2023
1 check passed
@lovell
Copy link
Contributor Author

lovell commented Dec 23, 2023

Ah, I wasn't aware of dumpversion, thanks for simplifying this.

@lovell lovell deleted the add-emscripten-version branch December 23, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants