-
Notifications
You must be signed in to change notification settings - Fork 6
Feat(validator)/claimer #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
4e39a03
feat: claimer
e6b5d7e
feat: happy path tests
829bd77
feat: claimer tests
fc5020c
feat: cli path tests
e367173
feat: increased test coverage
c488c4a
chore: outscoped claim fetch
a91a9c6
fix: verifySnapshot time flag
4ef27a7
fix: happy path logs
4c7d59a
chore: env.dist update
89b6b0b
feat: multi network support
cffaa00
chore: refactor for networks
9a7cc65
feat(validator): devent network support
025345e
chore(validator): refactor for network support
3a2ff60
chore(validator): update subgraph query for multi network
f7ec86f
chore(validator): type params & refactor
7b9ffa0
chore(validator): update tests for refactor
cd47f5f
chore(validator): remove old watcher
6e34daa
fix(validator): existence check
d66c455
chore(validator): udpdate rpc in env example
e4c617f
chore(validator): add custom error
c54c899
chore(validator): pm2 bump & removed web3 dep
f47ec8a
chore(validator): add no claim required log
b2bf8d8
fix(validator): claimable epoch calculation fix
13d6e2b
feat(validator): subgraph fallback for contract logs
979394b
chore(validator): update tests for subgraph fallback
de4b1b6
chore(validator): refactor for subgraph fallback
ee90f37
fix(validator): snapshot sent query fix
c3d2a23
chore(validator): update pm2 config
4aa595a
chore(validator): remove legacy devnet code
28e6095
chore(validator): remove unsused vars
23937af
fix(validator): add default cases
c9dbe57
chore(validator): refactor into helper ftns
30b174d
fix(validator): sonar review fixes
62f36b8
Merge branch 'dev' into feat(validator)/claimer
jaybuidl 9affefb
chore(validator): add params as object
84081ea
chore(validator): remove deprecated scripts
43e8021
chore(validator): remove unused imports & vars
e64c8a8
chore: merge dev
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,31 +1,20 @@ | ||
PRIVATE_KEY= | ||
|
||
# Devnet RPCs | ||
RPC_CHIADO=https://rpc.chiadochain.net | ||
RPC_ARB_SEPOLIA=https://sepolia-rollup.arbitrum.io/rpc | ||
RPC_SEPOLIA= | ||
# Networks: devnet, testnet, mainnet | ||
NETWORKS=devnet,testnet | ||
|
||
# Testnet or Mainnet RPCs | ||
|
||
# RPCs | ||
RPC_ARB=https://sepolia-rollup.arbitrum.io/rpc | ||
RPC_ETH= | ||
RPC_GNOSIS=https://rpc.chiadochain.net | ||
|
||
# Testnet or Mainnet Addresses | ||
# VEA Arbitrum to Ethereum | ||
VEAINBOX_ARB_TO_ETH_ADDRESS=0xE12daFE59Bc3A996362d54b37DFd2BA9279cAd06 | ||
VEAOUTBOX_ARB_TO_ETH_ADDRESS=0x209BFdC6B7c66b63A8382196Ba3d06619d0F12c9 | ||
# VEA Arbitrum to GNOSIS | ||
VEAINBOX_ARB_TO_GNOSIS_ADDRESS=0x854374483572FFcD4d0225290346279d0718240b | ||
VEAOUTBOX_ARB_TO_GNOSIS_ADDRESS=0x2f1788F7B74e01c4C85578748290467A5f063B0b | ||
VEAROUTER_ARB_TO_GNOSIS_ADDRESS=0x5BE03fDE7794Bc188416ba16932510Ed1277b193 | ||
GNOSIS_AMB_ADDRESS=0x8448E15d0e706C0298dECA99F0b4744030e59d7d | ||
|
||
VEAOUTBOX_CHAIN_ID=421611 | ||
GNOSIS_AMB_ADDRESS=0x8448E15d0e706C0298dECA99F0b4744030e59d7d | ||
|
||
# Devnet Addresses | ||
VEAINBOX_ARBSEPOLIA_TO_SEPOLIA_ADDRESS=0x906dE43dBef27639b1688Ac46532a16dc07Ce410 | ||
VEAOUTBOX_ARBSEPOLIA_TO_SEPOLIA_ADDRESS=0x906dE43dBef27639b1688Ac46532a16dc07Ce410 | ||
VEAOUTBOX_CHAINS=11155111,421611 | ||
|
||
# vescan subgraph endpoints | ||
VEAINBOX_SUBGRAPH=https://api.studio.thegraph.com/query/user/inbox-arb-sep/version/latest | ||
VEAOUTBOX_SUBGRAPH=https://api.studio.thegraph.com/query/user/outbox-arb-sep/version/latest | ||
|
||
TRANSACTION_BATCHER_CONTRACT_ADDRESS_SEPOLIA=0xe7953da7751063d0a41ba727c32c762d3523ade8 | ||
TRANSACTION_BATCHER_CONTRACT_ADDRESS_CHIADO=0xcC0a08D4BCC5f91ee9a1587608f7a2975EA75d73 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaybuidl marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,234 @@ | ||
import { ethers } from "ethers"; | ||
import { checkAndClaim, CheckAndClaimParams } from "./claimer"; | ||
import { ClaimHonestState } from "../utils/claim"; | ||
import { Network } from "../consts/bridgeRoutes"; | ||
|
||
describe("claimer", () => { | ||
const NETWORK = Network.DEVNET; | ||
let veaOutbox: any; | ||
let veaInbox: any; | ||
let veaInboxProvider: any; | ||
let veaOutboxProvider: any; | ||
let emitter: any; | ||
let mockClaim: any; | ||
let mockGetLatestClaimedEpoch: any; | ||
let mockGetTransactionHandler: any; | ||
let mockDeps: CheckAndClaimParams; | ||
|
||
let mockTransactionHandler: any; | ||
const mockTransactions = { | ||
claimTxn: "0x111", | ||
withdrawClaimDepositTxn: "0x222", | ||
startVerificationTxn: "0x333", | ||
verifySnapshotTxn: "0x444", | ||
devnetAdvanceStateTxn: "0x555", | ||
}; | ||
beforeEach(() => { | ||
mockClaim = { | ||
stateRoot: "0x1234", | ||
claimer: "0xFa00D29d378EDC57AA1006946F0fc6230a5E3288", | ||
timestampClaimed: 1234, | ||
timestampVerification: 0, | ||
blocknumberVerification: 0, | ||
honest: 0, | ||
challenger: ethers.ZeroAddress, | ||
}; | ||
veaInbox = { | ||
snapshots: jest.fn().mockResolvedValue(mockClaim.stateRoot), | ||
}; | ||
|
||
veaOutbox = { | ||
stateRoot: jest.fn().mockResolvedValue(mockClaim.stateRoot), | ||
}; | ||
veaOutboxProvider = { | ||
getBlock: jest.fn().mockResolvedValue({ number: 0, timestamp: 110 }), | ||
}; | ||
emitter = { | ||
emit: jest.fn(), | ||
}; | ||
|
||
mockGetLatestClaimedEpoch = jest.fn(); | ||
mockGetTransactionHandler = jest.fn().mockReturnValue(function DummyTransactionHandler(params: any) { | ||
// Return an object that matches our expected transaction handler. | ||
return mockTransactionHandler; | ||
}); | ||
mockDeps = { | ||
chainId: 0, | ||
claim: mockClaim, | ||
network: NETWORK, | ||
epoch: 10, | ||
epochPeriod: 10, | ||
veaInbox, | ||
veaInboxProvider, | ||
veaOutboxProvider, | ||
veaOutbox, | ||
transactionHandler: null, | ||
emitter, | ||
fetchLatestClaimedEpoch: mockGetLatestClaimedEpoch, | ||
now: 110000, // (epoch+ 1) * epochPeriod * 1000 for claimable epoch | ||
}; | ||
|
||
mockTransactionHandler = { | ||
withdrawClaimDeposit: jest.fn().mockImplementation(() => { | ||
mockTransactionHandler.transactions.withdrawClaimDepositTxn = mockTransactions.withdrawClaimDepositTxn; | ||
return Promise.resolve(); | ||
}), | ||
makeClaim: jest.fn().mockImplementation(() => { | ||
mockTransactionHandler.transactions.claimTxn = mockTransactions.claimTxn; | ||
return Promise.resolve(); | ||
}), | ||
startVerification: jest.fn().mockImplementation(() => { | ||
mockTransactionHandler.transactions.startVerificationTxn = mockTransactions.startVerificationTxn; | ||
return Promise.resolve(); | ||
}), | ||
verifySnapshot: jest.fn().mockImplementation(() => { | ||
mockTransactionHandler.transactions.verifySnapshotTxn = mockTransactions.verifySnapshotTxn; | ||
return Promise.resolve(); | ||
}), | ||
transactions: { | ||
claimTxn: "0x0", | ||
withdrawClaimDepositTxn: "0x0", | ||
startVerificationTxn: "0x0", | ||
verifySnapshotTxn: "0x0", | ||
}, | ||
}; | ||
}); | ||
afterEach(() => { | ||
jest.clearAllMocks(); | ||
}); | ||
describe("checkAndClaim", () => { | ||
beforeEach(() => { | ||
mockTransactionHandler = { | ||
withdrawClaimDeposit: jest.fn().mockImplementation(() => { | ||
mockTransactionHandler.transactions.withdrawClaimDepositTxn = mockTransactions.withdrawClaimDepositTxn; | ||
return Promise.resolve(); | ||
}), | ||
makeClaim: jest.fn().mockImplementation(() => { | ||
mockTransactionHandler.transactions.claimTxn = mockTransactions.claimTxn; | ||
return Promise.resolve(); | ||
}), | ||
startVerification: jest.fn().mockImplementation(() => { | ||
mockTransactionHandler.transactions.startVerificationTxn = mockTransactions.startVerificationTxn; | ||
return Promise.resolve(); | ||
}), | ||
verifySnapshot: jest.fn().mockImplementation(() => { | ||
mockTransactionHandler.transactions.verifySnapshotTxn = mockTransactions.verifySnapshotTxn; | ||
return Promise.resolve(); | ||
}), | ||
devnetAdvanceState: jest.fn().mockImplementation(() => { | ||
mockTransactionHandler.transactions.devnetAdvanceStateTxn = mockTransactions.devnetAdvanceStateTxn; | ||
return Promise.resolve(); | ||
}), | ||
transactions: { | ||
claimTxn: "0x0", | ||
withdrawClaimDepositTxn: "0x0", | ||
startVerificationTxn: "0x0", | ||
verifySnapshotTxn: "0x0", | ||
}, | ||
}; | ||
mockGetTransactionHandler = jest.fn().mockReturnValue(function DummyTransactionHandler(param: any) { | ||
return mockTransactionHandler; | ||
}); | ||
mockDeps.fetchTransactionHandler = mockGetTransactionHandler; | ||
}); | ||
it("should return null if no claim is made for a passed epoch", async () => { | ||
mockDeps.epoch = 7; // claimable epoch - 3 | ||
mockDeps.claim = null; | ||
|
||
mockDeps.fetchTransactionHandler = mockGetTransactionHandler; | ||
const result = await checkAndClaim(mockDeps); | ||
expect(result).toBeNull(); | ||
}); | ||
it("should return null if no snapshot is saved on the inbox for a claimable epoch", async () => { | ||
veaInbox.snapshots = jest.fn().mockResolvedValue(ethers.ZeroHash); | ||
mockGetLatestClaimedEpoch = jest.fn().mockResolvedValue({ | ||
challenged: false, | ||
stateroot: "0x1111", | ||
}); | ||
mockDeps.claim = null; | ||
mockDeps.fetchLatestClaimedEpoch = mockGetLatestClaimedEpoch; | ||
const result = await checkAndClaim(mockDeps); | ||
expect(result).toBeNull(); | ||
}); | ||
it("should return null if there are no new messages in the inbox", async () => { | ||
veaInbox.snapshots = jest.fn().mockResolvedValue(mockClaim.stateRoot); | ||
mockGetLatestClaimedEpoch = jest.fn().mockResolvedValue({ | ||
challenged: false, | ||
stateroot: "0x1111", | ||
}); | ||
mockDeps.claim = null; | ||
mockDeps.fetchLatestClaimedEpoch = mockGetLatestClaimedEpoch; | ||
const result = await checkAndClaim(mockDeps); | ||
expect(result).toBeNull(); | ||
}); | ||
describe("devnet", () => { | ||
beforeEach(() => { | ||
mockDeps.network = Network.DEVNET; | ||
}); | ||
it("should make a valid claim and advance state", async () => { | ||
veaInbox.snapshots = jest.fn().mockResolvedValue("0x7890"); | ||
mockGetLatestClaimedEpoch = jest.fn().mockResolvedValue({ | ||
challenged: false, | ||
stateroot: mockClaim.stateRoot, | ||
}); | ||
mockDeps.transactionHandler = mockTransactionHandler; | ||
mockDeps.fetchLatestClaimedEpoch = mockGetLatestClaimedEpoch; | ||
mockDeps.claim = null; | ||
mockDeps.veaInbox = veaInbox; | ||
const result = await checkAndClaim(mockDeps); | ||
expect(result.transactions.devnetAdvanceStateTxn).toBe(mockTransactions.devnetAdvanceStateTxn); | ||
}); | ||
}); | ||
describe("testnet", () => { | ||
beforeEach(() => { | ||
mockDeps.network = Network.TESTNET; | ||
}); | ||
it("should make a valid claim if no claim is made", async () => { | ||
veaInbox.snapshots = jest.fn().mockResolvedValue("0x7890"); | ||
mockGetLatestClaimedEpoch = jest.fn().mockResolvedValue({ | ||
challenged: false, | ||
stateroot: mockClaim.stateRoot, | ||
}); | ||
mockDeps.transactionHandler = mockTransactionHandler; | ||
mockDeps.fetchLatestClaimedEpoch = mockGetLatestClaimedEpoch; | ||
mockDeps.claim = null; | ||
mockDeps.veaInbox = veaInbox; | ||
const result = await checkAndClaim(mockDeps); | ||
expect(result.transactions.claimTxn).toBe(mockTransactions.claimTxn); | ||
}); | ||
it("should make a valid claim if last claim was challenged", async () => { | ||
veaInbox.snapshots = jest.fn().mockResolvedValue(mockClaim.stateRoot); | ||
mockGetLatestClaimedEpoch = jest.fn().mockResolvedValue({ | ||
challenged: true, | ||
stateroot: mockClaim.stateRoot, | ||
}); | ||
mockDeps.transactionHandler = mockTransactionHandler; | ||
mockDeps.fetchLatestClaimedEpoch = mockGetLatestClaimedEpoch; | ||
mockDeps.claim = null; | ||
mockDeps.veaInbox = veaInbox; | ||
const result = await checkAndClaim(mockDeps); | ||
expect(result.transactions.claimTxn).toEqual(mockTransactions.claimTxn); | ||
}); | ||
it("should withdraw claim deposit if claimer is honest", async () => { | ||
mockDeps.transactionHandler = mockTransactionHandler; | ||
mockClaim.honest = ClaimHonestState.CLAIMER; | ||
const result = await checkAndClaim(mockDeps); | ||
expect(result.transactions.withdrawClaimDepositTxn).toEqual(mockTransactions.withdrawClaimDepositTxn); | ||
}); | ||
it("should start verification if verification is not started", async () => { | ||
mockDeps.transactionHandler = mockTransactionHandler; | ||
mockClaim.honest = ClaimHonestState.NONE; | ||
const result = await checkAndClaim(mockDeps); | ||
expect(result.transactions.startVerificationTxn).toEqual(mockTransactions.startVerificationTxn); | ||
}); | ||
it("should verify snapshot if verification is started", async () => { | ||
mockDeps.transactionHandler = mockTransactionHandler; | ||
mockClaim.honest = ClaimHonestState.NONE; | ||
mockClaim.timestampVerification = 1234; | ||
mockDeps.claim = mockClaim; | ||
const result = await checkAndClaim(mockDeps); | ||
expect(result.transactions.verifySnapshotTxn).toEqual(mockTransactions.verifySnapshotTxn); | ||
}); | ||
}); | ||
}); | ||
}); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.