Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding startup probes #6042

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Adding startup probes #6042

merged 2 commits into from
Jul 15, 2024

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Jul 8, 2024

Documents knative/serving#10037 / knative/serving#15309.

Proposed Changes

  • Add docs for startup probe support

/hold for knative/serving#15309 to be merged first.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2024
@ReToCode
Copy link
Member Author

ReToCode commented Jul 8, 2024

/assign @skonto
/assign @dprotaso

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 8, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from Cali0707 and skonto July 8, 2024 06:09
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 8, 2024 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b5f372f
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/668e1ced7c9b820008d8bad9
😎 Deploy Preview https://deploy-preview-6042--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ReToCode
Copy link
Member Author

Thanks @skonto. Updated with review improvements. PTAL.

@ReToCode
Copy link
Member Author

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2024
@skonto
Copy link
Contributor

skonto commented Jul 10, 2024

/lgtm

/hold for @dprotaso

@knative-prow knative-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jul 10, 2024
@ReToCode
Copy link
Member Author

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2024
@knative-prow knative-prow bot merged commit 99226fc into knative:main Jul 15, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skonto skonto skonto left review comments

@Cali0707 Cali0707 Awaiting requested review from Cali0707

Assignees

@dprotaso dprotaso

@skonto skonto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ReToCode @skonto @dprotaso