Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better cleaup for Java template tests #2051

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

matejvasek
Copy link
Contributor

No description provided.

@knative-prow knative-prow bot requested review from dsimansk and maximilien October 24, 2023 19:08
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2023
@matejvasek matejvasek requested review from jrangelramos, gauron99 and lkingland and removed request for maximilien and dsimansk October 24, 2023 19:08
@matejvasek matejvasek force-pushed the fix-java-template-tests branch from 1a90780 to 16959c2 Compare October 24, 2023 19:18
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a2db8e) 63.64% compared to head (16959c2) 64.64%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2051      +/-   ##
==========================================
+ Coverage   63.64%   64.64%   +1.00%     
==========================================
  Files         107      107              
  Lines       13700    13700              
==========================================
+ Hits         8720     8857     +137     
+ Misses       4125     3965     -160     
- Partials      855      878      +23     
Flag Coverage Δ
e2e-test 36.46% <ø> (ø)
e2e-test-oncluster 30.53% <ø> (ø)
e2e-test-oncluster-runtime 26.96% <ø> (?)
e2e-test-runtime-go 25.50% <ø> (?)
e2e-test-runtime-node 26.60% <ø> (?)
e2e-test-runtime-quarkus 26.71% <ø> (?)
e2e-test-runtime-springboot 25.73% <ø> (?)
e2e-test-runtime-typescript 26.68% <ø> (?)
integration-tests 51.90% <ø> (+2.05%) ⬆️
unit-tests-macos-latest 48.76% <ø> (-0.03%) ⬇️
unit-tests-ubuntu-latest 49.56% <ø> (+0.04%) ⬆️
unit-tests-windows-latest 48.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor Author

PTAL @jrangelramos @gauron99 @lkingland

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 7fa331b into knative:main Oct 26, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants