Differentiate between podman and docker for local registry connection #2063
Conversation
Signed-off-by: Matthias Wessendorf <[email protected]>
knative-prow
bot
added
the
size/S
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
| docker run -d --restart=always -p "127.0.0.1:50000:5000" --name "func-registry" registry:2 | ||
| docker network connect "kind" "func-registry" | ||
| elif [ "$CONTAINER_ENGINE" == "podman" ]; then | ||
| docker run -d --restart=always -p "127.0.0.1:50000:5000" --net=kind --name "func-registry" registry:2 |
There was a problem hiding this comment.
Shouldn't this be podman or "${CONTAINER_ENGINE}"?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2063 +/- ##
==========================================
+ Coverage 62.54% 64.59% +2.04%
==========================================
Files 107 107
Lines 13703 13703
==========================================
+ Hits 8571 8851 +280
+ Misses 4303 3971 -332
- Partials 829 881 +52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/lgtm |
Changes
podmananddockerto theallocate.shFixes #2059