Remove dependency on docker hub #2654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
approved
knative-prow
bot
added
the
size/M
matejvasek
requested review from
matzew
and removed request for
rhuss and
vyasgun
Signed-off-by: Matej Vašek <[email protected]>
matejvasek
force-pushed
the
rm-docker-hub
branch
from
a007bc1 to
bce5a3c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2654 +/- ##
==========================================
+ Coverage 64.13% 65.44% +1.30%
==========================================
Files 130 130
Lines 15518 15518
==========================================
+ Hits 9953 10155 +202
+ Misses 4625 4387 -238
- Partials 940 976 +36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@lkingland @matzew @dsimansk PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed dependency on
index.docker.io/library/golang:1.23-alpine3.20andindex.docker.io/library/alpine:latest.For future I consider making the image
scratchor at leastdistrolessbut for now it's stillalpine.Also we might consider skipping the
builderpart -- we could build the binaries locally and then useCOPY.Also I hate the fact that the
ADDclause do not have--fromflag, because of that I have to do fetching outside of theDockerfile.