Skip to content

test: fix python e2e http test #2831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

jrangelramos
Copy link
Contributor

Changes

  • 🧹 Fix python test.

Default python functions no longer echoes as response what it receives from request. It just returns "OK", so this fix python tests used on midstream

@knative-prow knative-prow bot requested review from dsimansk and nainaz May 14, 2025 14:12
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 14, 2025
@jrangelramos jrangelramos requested a review from matejvasek May 14, 2025 14:12
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2025
Copy link

knative-prow bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrangelramos, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jrangelramos,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.49%. Comparing base (535d6de) to head (0925123).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2831      +/-   ##
==========================================
+ Coverage   62.66%   63.49%   +0.82%     
==========================================
  Files         127      127              
  Lines       15545    15545              
==========================================
+ Hits         9742     9870     +128     
+ Misses       4892     4736     -156     
- Partials      911      939      +28     
Flag Coverage Δ
e2e-tests 43.63% <ø> (+1.42%) ⬆️
integration-tests 49.48% <ø> (+1.87%) ⬆️
unit-tests 49.55% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matejvasek
Copy link
Contributor

@jrangelramos any ideas why the test is faling?

@matejvasek
Copy link
Contributor

/override "Func E2E OnCluster Test / On Cluster Test (ubuntu-latest)"

Copy link

knative-prow bot commented May 26, 2025

@matejvasek: matejvasek unauthorized: /override is restricted to Repo administrators, and the following github teams:knative: knative-release-leads client-wg-leads eventing-wg-leads functions-wg-leads productivity-wg-leads serving-wg-leads.

In response to this:

/override "Func E2E OnCluster Test / On Cluster Test (ubuntu-latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matejvasek
Copy link
Contributor

@lkingland could you please override the action?

@matejvasek
Copy link
Contributor

@dsimansk could you please override the action?

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label May 27, 2025
@dsimansk
Copy link
Contributor

/override ?

Copy link

knative-prow bot commented May 27, 2025

@dsimansk: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ?

Only the following failed contexts/checkruns were expected:

  • E2E Test (ubuntu-latest, node)
  • EasyCLA
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • tide
  • unit-tests_func_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dsimansk
Copy link
Contributor

/override "E2E Test (ubuntu-latest, node)"

Copy link

knative-prow bot commented May 27, 2025

@dsimansk: Overrode contexts on behalf of dsimansk: E2E Test (ubuntu-latest, node)

In response to this:

/override "E2E Test (ubuntu-latest, node)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matejvasek
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2025
@knative-prow knative-prow bot merged commit 70720ed into knative:main May 27, 2025
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants