Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #12 - Added app labels to model list dialog #25

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Fixed #12 - Added app labels to model list dialog #25

merged 1 commit into from
Jun 8, 2024

Conversation

erosselli
Copy link
Collaborator

Fixes #12.

I'll probably switch the label for a search icon + aria-label (for consistency with existing search inputs) in #7.

Screen recording

Screen.Recording.2024-06-08.at.16.21.07.mov

@erosselli erosselli requested a review from knyghty June 8, 2024 14:25
@coveralls
Copy link

coveralls commented Jun 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9429427024

Details

  • 1 of 8 (12.5%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-9.7%) to 69.388%
Changes Missing Coverage Covered Lines Changed/Added Lines %
django_admin_keyboard_shortcuts/templatetags/shortcuts.py 1 8 12.5%
Totals Coverage Status
Change from base Build 9429077554: -9.7%
Covered Lines: 32
Relevant Lines: 43
💛 - Coveralls

@erosselli erosselli force-pushed the issue-12-app-labels-in-model-list branch from 6b3d5ea to a1e2534 Compare June 8, 2024 14:27
@coveralls
Copy link

coveralls commented Jun 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9429440773

Details

  • 1 of 7 (14.29%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-8.2%) to 70.833%
Changes Missing Coverage Covered Lines Changed/Added Lines %
django_admin_keyboard_shortcuts/templatetags/shortcuts.py 1 7 14.29%
Totals Coverage Status
Change from base Build 9429077554: -8.2%
Covered Lines: 32
Relevant Lines: 42
💛 - Coveralls

knyghty
knyghty approved these changes Jun 8, 2024
View reviewed changes
Copy link
Owner

@knyghty knyghty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's some opportunity for cleanup here but I will look into that when there's not as much frenetic activity on the repo.

@knyghty knyghty merged commit 150c376 into main Jun 8, 2024
9 checks passed
@knyghty knyghty deleted the issue-12-app-labels-in-model-list branch June 8, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knyghty knyghty knyghty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add app labels to model list dialog
3 participants
@erosselli @coveralls @knyghty