Update awslabs/amazon-ecr-credential-helper to latest #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update fixes an apparent conflict between the amazon-ecr-credential-helper library and the aws-sdk-go-v2 library, introduced when aws-sdk-go-v2 was updated as a byproduct of a cosign upgrade in #1191. This mismatch resulted in an error: "ecr: Failed to get authorization token: not found, ResolveEndpointV2" However, this error was not readily apparent due to overridding the ecr-login module's logger to io.Discard in pkg/commands/config.go. Resolves: #1245 Signed-off-by: Eric Searcy <[email protected]>
Result of running ./hack/update-codegen.sh Signed-off-by: Eric Searcy <[email protected]>
|
some work is still required in order to merge this pr before reviewing |
|
Please merge this we are unable to use OIDC until the underline ecr-login is updated. This is the error And after the ecr-login is updated everything works
|
nesty92
reviewed
Mar 26, 2024
| @@ -3,7 +3,7 @@ module github.com/google/ko | |||
| go 1.21 | |||
|
|
|||
| require ( | |||
| github.com/awslabs/amazon-ecr-credential-helper/ecr-login v0.0.0-20231024185945-8841054dbdb8 | |||
| github.com/awslabs/amazon-ecr-credential-helper/ecr-login v0.0.0-20231121035052-cd92a7ab1375 | |||
There was a problem hiding this comment.
Why not updating to the latest version v0.0.0-20240323062759-1fd604ae58de ?
|
Since #1267 was merged this one can be close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update fixes an apparent conflict between the amazon-ecr-credential-helper library and the aws-sdk-go-v2 library, introduced when aws-sdk-go-v2 was updated as a byproduct of a cosign upgrade in #1191.
This mismatch resulted in an error:
ecr: Failed to get authorization token: not found, ResolveEndpointV2However, this error was not readily apparent due to overridding the ecr-login module's logger to io.Discard in
pkg/commands/config.go.Resolves: #1245