Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update recorder to lazy create file. #1379

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Update recorder to lazy create file. #1379

merged 2 commits into from
Oct 16, 2024

Commits on Oct 16, 2024

  1. Update recorder to lazy create file. 

    Currently the resolver command creates the image-refs file on
initilization. This causes git to be dirty during builds. This change moves the
file creation to be in the recorder itself and on the first time the Publish()
method is called. This happens after the build so git is clean. This will mean
that any errors on file creation will be reported after the build rather than
before.

Signed-off-by: Jeff Mendoza <[email protected]>
    @jeffmendoza
    jeffmendoza committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b7521de View commit details
    Browse the repository at this point in the history

  2. Update doc comment 

    Signed-off-by: Jeff Mendoza <[email protected]>
    @jeffmendoza
    jeffmendoza committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    31bf4b1 View commit details
    Browse the repository at this point in the history