Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Price sort by logic #11075

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Oct 2, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Screenshot 📸

  • My fix has changed something on UI;

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 2a155d9
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/674802c90cd07f00086317a3
😎 Deploy Preview https://deploy-preview-11075--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hassnian hassnian mentioned this pull request Oct 2, 2024
6 tasks
@hassnian
Copy link
Contributor Author

hassnian commented Oct 2, 2024

issue with token entity query ❌

irrc I've seen this issue linked in another pr @Jarsen136 did you have a look?

CleanShot 2024-10-02 at 17 51 26@2x

nft entities ✅
CleanShot 2024-10-02 at 17 53 24@2x

@Jarsen136
Copy link
Contributor

issue with token entity query ❌

irrc I've seen this issue linked in another pr @Jarsen136 did you have a look?

You may be talking about this fix https://github.com/kodadot/stick/pull/312/files

I test it here but cant reproduce the error https://ahk.gql.api.kodadot.xyz/
image

@vikiival
Copy link
Member

vikiival commented Oct 7, 2024

Stick v12 should be also updated

@hassnian
Copy link
Contributor Author

@vikiival the new filter is working on ahk but not on ahp , is ahp re-deployed ?

CleanShot 2024-10-21 at 08 54 13@2x

Copy link

sonarcloud bot commented Oct 21, 2024

@vikiival
Copy link
Member

@vikiival
Copy link
Member

Same as #11176 ?

@hassnian
Copy link
Contributor Author

Yes

https://github.com/kodadot/stick/compare/release-speck...main?expand=1

👀

Same as #11176 ?

unrelated, #11176 is about listing not working in /explore/items

@vikiival
Copy link
Member

👀

Like it was already released, if you find any issues please open an issue in the stick. 🫶

Copy link

sonarcloud bot commented Nov 28, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Price sort by logic
3 participants