✨ remove empty rmrk collections

[roiLeo]

continue #2705

⚠️ Listed => "BUY NOW" isn't working

PR type

• Bugfix
• Feature

What's new?

• PR closes Do not show empty collections - Better filters on Collections view  #1357
• related with Add the Option to search for the name on the collection #1231
• remove empty collection on rmrk /collections using subsquid

Before submitting Pull Request, please make sure:

• My contribution builds clean without any errors or warnings
• I've merged recent default branch -- main and I've no conflicts
• I've tried to respect high code quality standards
• I've didn't break any original functionality
• I've posted a screenshot of demonstrated change in this PR

Screenshot

before

after

Had issue bounty label?

• Fill up your KSM address: Payout

[netlify]

✅ Deploy Preview for koda-nuxt ready!

Name	Link
🔨 Latest commit	744bf57
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/6256a15a4919e20008a61b1f
😎 Deploy Preview	https://deploy-preview-2718--koda-nuxt.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[yangwao]

Hence we will be doing unification I guess we can fix this bug later? #2719

[roiLeo]

Hence we will be doing unification I guess we can fix this bug later? #2719

This can be done now or later, I wanted to try #2705 fix since #1357 is a problem that we have had for a long time

[vikiival]

Wow love the change but It would break a ton of stuff.
However I need to come up with some compatibility layer vikiival/kodapi#6

[yangwao]

Once we do

• Unification explorer + collections into one  #2719
• #2719 Unification explorer + collections into one #2812
  this would be really needed to have :)

[vikiival]

plese do not change the query, rather create new under /queries/rmrk/subsquid

[roiLeo]

made some changes <CollectionList /> component (with subsquid query & filters) is only used in /rmrk/collections

[vikiival]

@yangwao thinking to merge this inb4 #2812

[yangwao]

@yangwao thinking to merge this inb4 #2812

Make sense, or at least both merged before going live yes

[vikiival]

Can we have buy now? 🥺 Happy to help you with that

[roiLeo]

Can we have buy now? 🥺 Happy to help you with that

Buy now filter in /collections is no longer present
don't know why but I couldn't push my changes so I may have force push 🍴

[yangwao]

Make follow up the issue on buy now?

[vikiival]

Make follow up the issue on buy now?

@yangwao we broke main :) so check netlify logs pls

[yangwao]

https://app.netlify.com/teams/yangwao/builds/625549e849e59900089b0d26

Deploy did not succeed: Deploy directory 'dist' does not exist

[yangwao]

Once #2831 merged into main should be merged here tho

[yangwao]

Let's merge it and open follow up the issue?
I guess it's huge improvement tho not seeing empty collections there :)

[roiLeo]

Let's merge it and open follow up the issue? I guess it's huge improvement tho not seeing empty collections there :)

Sure, new issue will be to display again Collections Sort & Filters

[yangwao]

If there are no objections, let's merge it and continue to

• Collections Sort by #2845
• Can we have collection first in explore? #2840

[vikiival]

pay 100 usd

[roiLeo]

pay 100

[yangwao]

😍 Perfect, I’ve sent the payout
💵 $100 @ 152.5 USD/KSM ~ 0.656 $KSM
🧗 GemsyWUUtZU5HAiEQJqqgVz4YkekKXnmutYryBhbcVD4YW3
🔗 0xcc3a46893bc80b5eb4c0b1e46688342718a5621dd643e776035b5ddafa8bb64d

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues