-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add volume sort to ExploreSort #5699
feat: Add volume sort to ExploreSort #5699
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request adds a new volume sort feature to the ExploreSort menu. The changes include adding two new sorting options, "Most Volume" and "Least Volume," to both the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any sorting by volume option in collectionEntities
Volume sorting is supported in latest unreleased indexer, no ETA on the release (but should be soon) |
This is changed only on rubick indexer, we need to change |
Oh shoot, you are right, that change was not merged yet (kodadot/snek#170). |
…ore-collections-sort
marckV3 seems synced, is it stable already @vikiival ? |
Synced and using on prod |
@Matehoo this can go out I guess? |
We can still conditionally render that for snek and marck const { urlPrefix } = usePrefix()
['bsx', 'ksm'].includes(urlPrefix.value) |
please release 004 as this won't work on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
snek https://squid.subsquid.io/sneck/graphql
has been released in #6125
@vikiival Do you have ETA for rubick release? |
Made low budget release of rubick should be up soon Supplemental as I have false positives |
Please don't forget snekk 004 |
oof so short adventure |
I already made deploy for it https://app.subsquid.io/squids/sneck/v1
|
Oooh didn't knew about that one, then we need to update snek endpoint (we still query 004) |
any updates? |
…-volume-to-explore-collections-sort
…-volume-to-explore-collections-sort
Code Climate has analyzed commit 4eb48a1 and detected 0 issues on this pull request. View more on Code Climate. |
rubick updated in 4eb48a1 |
Kudos, SonarCloud Quality Gate passed!
|
@prury can you check this one 😌 and then let's merge it |
Oki thanks will recheck |
Can we have it merged? |
Not yet |
Do you remember what was the issue with marck v3? 🥺 It is needed for this. |
no, link to issue?
maybe do some hotfix or exclude volume sort for that for now. |
Most probably this was the reason |
But that's 4 mo old? |
Won't make it for now |
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type
Context
Before submitting pull request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot 📸