Skip to content

Commit

Permalink
fix job name invalid
Browse files Browse the repository at this point in the history
Signed-off-by: Patrick Zhao <[email protected]>
  • Loading branch information
PetrusZ committed Dec 4, 2024
1 parent 20977c8 commit b46b682
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -198,5 +198,7 @@ func GenJobName(workflow *commonmodels.WorkflowV4, jobName string, subTaskID int
}
}

return fmt.Sprintf("job-%d-%d-%d-%s-%s", stageIndex, jobIndex, subTaskID, stageName, jobName)
_ = stageName

return fmt.Sprintf("job-%d-%d-%d-%s", stageIndex, jobIndex, subTaskID, jobName)
}
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ func (s *ToolInstallStep) runIntallationScripts(tool *step.Tool) error {
fileName := filepath[len(filepath)-1]

tmpPath = path.Join(os.TempDir(), fileName)
log.Debugf("provider is %s", s.spec.S3Storage.Provider)
s3client, err := s3tool.NewClient(s.spec.S3Storage.Endpoint, s.spec.S3Storage.Ak, s.spec.S3Storage.Sk, s.spec.S3Storage.Region, s.spec.S3Storage.Insecure, s.spec.S3Storage.Provider)
if err == nil {
objectKey := GetObjectPath(fileName, s.spec.S3Storage.Subfolder)
Expand Down

0 comments on commit b46b682

Please sign in to comment.