Skip to content

Commit

Permalink
Fix absolutely shameful bug that caused some reviews to not be loaded.
Browse files Browse the repository at this point in the history
If a paper is in PHASE_FINAL, the old code mistook that as meaning
the paper had full reviews loaded, whether or not it did.
  • Loading branch information
kohler committed Feb 8, 2024
1 parent 0a03972 commit 09f574a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/paperinfo.php
Original file line number Diff line number Diff line change
Expand Up @@ -1034,7 +1034,7 @@ function phase() {
} else {
$phase = self::PHASE_REVIEW;
}
$this->_flags = ($phase & ~self::PHASE_MASK) | self::HAS_PHASE | ($phase << self::PHASE_SHIFT);
$this->_flags = ($this->_flags & ~self::PHASE_MASK) | self::HAS_PHASE | ($phase << self::PHASE_SHIFT);
}
return ($this->_flags & self::PHASE_MASK) >> self::PHASE_SHIFT;
}
Expand Down

0 comments on commit 09f574a

Please sign in to comment.