Avoid SQL error if settings are fucked.

kohler · Sep 28, 2023 · 6b8d82e · 6b8d82e
1 parent 774eb6c
commit 6b8d82e
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/contact.php b/src/contact.php
@@ -5555,6 +5555,8 @@ function assign_review($pid, $reviewer_cid, $type, $extra = []) {
             return $reviewId;
         } else if ($oldtype === 0) {
             $round = $round ?? $this->conf->assignment_round($type === REVIEW_EXTERNAL);
+            assert($round !== null); // `null` should not happen
+            $round = $round ?? 0;
             if (($new_requester = $extra["requester_contact"] ?? null)) {
                 $new_requester_cid = $new_requester->contactId;
             }