Do not set AUSEEN_LIVE bit unless could notify

kohler · Sep 12, 2024 · 6bdc035 · 6bdc035
1 parent 5df9b42
commit 6bdc035
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/src/conference.php b/src/conference.php
@@ -360,7 +360,7 @@ function __load_settings() {
 
     function load_settings() {
         $this->__load_settings();
-        if ($this->sversion < 303) {
+        if ($this->sversion < 304) {
             $old_nerrors = Dbl::$nerrors;
             while ((new UpdateSchema($this))->run()) {
                 usleep(50000);

diff --git a/src/reviewvalues.php b/src/reviewvalues.php
@@ -1001,6 +1001,8 @@ private function _apply_req(Contact $user, PaperInfo $prow, ReviewInfo $rrow, $n
             && $diffinfo->view_score() >= $author_view_score
             && $prow->can_author_view_submitted_review()) {
             $rflags |= ReviewInfo::RF_AUSEEN_LIVE;
+        } else {
+            $rflags &= ~ReviewInfo::RF_AUSEEN_LIVE;
         }
 
         // potentially assign review ordinal (requires table locking since

diff --git a/src/schema.sql b/src/schema.sql
@@ -627,7 +627,7 @@ CREATE TABLE `TopicInterest` (
 -- Initial settings
 -- (each setting must be on its own line for createdb.php/createdb.sh)
 insert into Settings (name, value, data) values
-  ('allowPaperOption', 303, null),   -- schema version
+  ('allowPaperOption', 304, null),   -- schema version
   ('setupPhase', 1, null),           -- initial user is chair
   ('no_papersub', 1, null),          -- no submissions yet
   ('sub_pcconf', 1, null),           -- collect PC conflicts, not collaborators

diff --git a/src/updateschema.php b/src/updateschema.php
@@ -3144,6 +3144,11 @@ function run() {
             && $conf->ql_ok("update PaperReviewHistory set rflags=rflags&~? where rflags>=? and (rflags&?)=0", self::RF_AUSEEN_LIVE_v299, self::RF_AUSEEN_LIVE_v299, self::RF_AUSEEN_v297)) {
             $conf->update_schema_version(303);
         }
+        if ($conf->sversion === 303
+            && $conf->ql_ok("update PaperReview set rflags=rflags&~? where rflags>=? and reviewAuthorNotified=0", self::RF_AUSEEN_LIVE_v299, self::RF_AUSEEN_LIVE_v299)
+            && $conf->ql_ok("update PaperReviewHistory set rflags=rflags&~? where rflags>=? and reviewAuthorNotified=0", self::RF_AUSEEN_LIVE_v299, self::RF_AUSEEN_LIVE_v299)) {
+            $conf->update_schema_version(304);
+        }
 
         $conf->ql_ok("delete from Settings where name='__schema_lock'");
         Conf::$main = $old_conf_g;