Unconditionally enable new form of field:none search.

Tests on HotCRP.com indicate equivalence for all configured searches.
kohler · Mar 13, 2024 · 8e604aa · 8e604aa
1 parent cf1e448
commit 8e604aa
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/src/reviewsearchmatcher.php b/src/reviewsearchmatcher.php
@@ -459,13 +459,9 @@ function test_review(Contact $user, PaperInfo $prow, ReviewInfo $rrow) {
                 return false;
             }
             $rf = $this->rfsrch->rf;
-            if ($rf->view_score <= $user->view_score_bound($prow, $rrow)) {
-                return false;
-            }
-            $fvx = $rf->test_exists($rrow);
-            $fv = $fvx ? $rrow->fields[$rf->order] : null;
-            if ((self::$mode === 1 && !$fvx)
-                || !$this->rfsrch->test_value($rrow, $fv)) {
+            if ($rf->view_score <= $user->view_score_bound($prow, $rrow)
+                || !$rf->test_exists($rrow)
+                || !$this->rfsrch->test_value($rrow, $rrow->fields[$rf->order])) {
                 return false;
             }
         }