Skip to content

Commit

Permalink
Remove obsolete assertions.
Browse files Browse the repository at this point in the history
A user might provide a garbage request that's not simple.
  • Loading branch information
kohler committed Mar 12, 2024
1 parent c74a71b commit ca3cee2
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion src/pages/p_assign.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ function assign_load() {
throw $whynot;
}
} catch (Redirection $redir) {
assert(PaperRequest::simple_qreq($this->qreq));
throw $redir;
} catch (PermissionProblem $perm) {
$this->error_exit(MessageItem::error("<5>" . $perm->unparse_html()));
Expand Down
1 change: 0 additions & 1 deletion src/pages/p_paper.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ function load_prow() {
$pr = new PaperRequest($this->qreq, false);
$this->prow = $this->conf->paper = $pr->prow;
} catch (Redirection $redir) {
assert(PaperRequest::simple_qreq($this->qreq));
throw $redir;
} catch (PermissionProblem $perm) {
$this->error_exit($perm);
Expand Down
1 change: 0 additions & 1 deletion src/pages/p_review.php
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ function load_prow() {
$this->rrow_explicit = false;
}
} catch (Redirection $redir) {
assert(PaperRequest::simple_qreq($this->qreq));
throw $redir;
} catch (PermissionProblem $perm) {
$perm->set("listViewable", $this->user->is_author() || $this->user->is_reviewer());
Expand Down

0 comments on commit ca3cee2

Please sign in to comment.