Improve auto placeholder behavior.

kohler · Sep 26, 2023 · fe9e6ea · fe9e6ea
1 parent c30f904
commit fe9e6ea
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/settingparser.php b/src/settingparser.php
@@ -15,7 +15,7 @@ function json_values(Si $si, SettingValues $sv) {
 
     /** @return ?string */
     function placeholder(Si $si, SettingValues $sv) {
-        return null;
+        return "auto";
     }
 
     /** @return ?string */

diff --git a/src/si.php b/src/si.php
@@ -565,9 +565,8 @@ function json_values($sv) {
      * @return ?string */
     function placeholder($sv) {
         if ($this->placeholder === "auto"
-            && $this->parser_class
-            && ($v = $sv->si_parser($this)->placeholder($this, $sv)) !== null) {
-            return $v;
+            && $this->parser_class) {
+            return $sv->si_parser($this)->placeholder($this, $sv);
         } else {
             return $this->placeholder;
         }