Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about keyframe #75

Open
redheli opened this issue Sep 13, 2024 · 1 comment
Open

about keyframe #75

redheli opened this issue Sep 13, 2024 · 1 comment

Comments

@redheli
Copy link

redheli commented Sep 13, 2024

Hi, I really like the keyframe video and would love to contribute to the codebase.
However, I have a couple of questions:

Is the keyframe concept considered a factor in the graph, similar to how unary factors, prior factors, and between factors are used in a GTSAM pose graph?

Thank you for your guidance!

@koide3
Copy link
Owner

koide3 commented Sep 21, 2024

Thanks. The keyframe concept is built on a factor graph, but it does not use traditional pose factors (i.e., gtsam::PriorFactor<Pose3> nor gtsam::BetweenFactor<Pose3>). Instead, it uses factors that directly compute multi-frame point cloud registration errors, resulting in better robustness and accuracy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants