feat: add ginkgolinter (#701)

* test: add ginkgolinter to golangci * fix: apply ginkgolinter suggestions
konflux-ci · Aug 15, 2023 · 88bd3e4 · 88bd3e4
1 parent e4581f0
commit 88bd3e4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -1,3 +1,6 @@
 issues:
   exclude:
     - composites
+linters:
+  enable:
+    - ginkgolinter
diff --git a/tests/build/build.go b/tests/build/build.go
@@ -655,7 +655,7 @@ var _ = framework.BuildSuiteDescribe("Build service E2E tests", Label("build", "
 			Specify("simple build can be triggered manually", func() {
 				Expect(f.AsKubeAdmin.HasController.SetComponentAnnotation(componentName, controllers.BuildRequestAnnotationName, controllers.BuildRequestTriggerSimpleBuildAnnotationValue, testNamespace)).To(Succeed())
 
-				Expect(f.AsKubeAdmin.HasController.WaitForComponentPipelineToBeFinished(component, "", 2))
+				Expect(f.AsKubeAdmin.HasController.WaitForComponentPipelineToBeFinished(component, "", 2)).To(Succeed())
 
 				var buildStatus *controllers.BuildStatus
 
@@ -683,7 +683,7 @@ var _ = framework.BuildSuiteDescribe("Build service E2E tests", Label("build", "
 					return buildStatus.Simple != nil && buildStatus.Simple.BuildStartTime != lastBuildStartTime && buildStatus.Simple.ErrId == 0 && buildStatus.Simple.ErrMessage == "", nil
 				}, timeout, interval).Should(BeTrue(), "build status has unexpected content")
 
-				Expect(f.AsKubeAdmin.TektonController.DeleteAllPipelineRunsInASpecificNamespace(testNamespace))
+				Expect(f.AsKubeAdmin.TektonController.DeleteAllPipelineRunsInASpecificNamespace(testNamespace)).To(Succeed())
 			})
 		})