-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Mention the usage of lighter bundle for builds #1528
docs: Mention the usage of lighter bundle for builds #1528
Conversation
* and fix some dead links Signed-off-by: Dheeraj<[email protected]>
* this would help users to know which repo they need to fork to their Org, in order to run the specific e2e test(s) Signed-off-by: Dheeraj<[email protected]>
@jencull do you need me to add anything else in this PR? |
this came up yesterday in team chat "Wait, there's GITLAB_BOT_TOKEN in the user.env, but the PAC_GITLAB_TOKEN is only in the preview-template.env, and it looks like PAC_GITLAB_TOKEN is the one that's required for webhooks. So we need to set both in other to make it work" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/lgtm |
@dheerajodha: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dheerajodha, jencull The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Issue ticket number and link
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: