Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Mention the usage of lighter bundle for builds #1528

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

dheerajodha
Copy link
Member

Description

  • Mention the usage of lighter bundle for builds in our guide
  • and fix some dead redirects

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

* and fix some dead links

Signed-off-by: Dheeraj<[email protected]>
@openshift-ci openshift-ci bot requested review from jinqi7 and kasemAlem March 4, 2025 14:05
@dheerajodha dheerajodha requested a review from jencull March 4, 2025 14:05
@dheerajodha dheerajodha requested a review from jsztuka March 4, 2025 17:22
* this would help users to know which repo
  they need to fork to their Org, in order
  to run the specific e2e test(s)

Signed-off-by: Dheeraj<[email protected]>
@dheerajodha
Copy link
Member Author

@jencull do you need me to add anything else in this PR?

@jencull
Copy link
Contributor

jencull commented Mar 7, 2025

@jencull do you need me to add anything else in this PR?

this came up yesterday in team chat "Wait, there's GITLAB_BOT_TOKEN in the user.env, but the PAC_GITLAB_TOKEN is only in the preview-template.env, and it looks like PAC_GITLAB_TOKEN is the one that's required for webhooks. So we need to set both in other to make it work"

Copy link
Contributor

@jencull jencull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dheerajodha
Copy link
Member Author

/lgtm
/approve

Copy link

openshift-ci bot commented Mar 7, 2025

@dheerajodha: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the approved label Mar 7, 2025
@jencull
Copy link
Contributor

jencull commented Mar 7, 2025

/lgtm
/approve

Copy link

openshift-ci bot commented Mar 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dheerajodha, jencull

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ad297c9 into konflux-ci:main Mar 7, 2025
10 checks passed
@dheerajodha dheerajodha deleted the update-e2e-readme branch March 7, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants