Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: azure domains endpoint #469

Merged
merged 9 commits into from
Dec 5, 2024
Merged

feat: azure domains endpoint #469

merged 9 commits into from
Dec 5, 2024

Conversation

CristhianF7
Copy link
Contributor

@CristhianF7 CristhianF7 commented Nov 18, 2024 •
edited
Loading

Description

  • Azure domain endpoint
  • Store install kubefirst pro flag
  • Fix cluster secret reference was being added twice

patrickdappollonio
patrickdappollonio previously approved these changes Nov 18, 2024
View reviewed changes
internal/router/api/v1/domain.go Outdated Show resolved Hide resolved
patrickdappollonio
patrickdappollonio previously approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@patrickdappollonio patrickdappollonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving you some food for thought. Nothing that needs to be fixed right now, because those are everywhere in the API anyways.

internal/router/api/v1/domain.go Outdated Show resolved Hide resolved
internal/router/api/v1/domain.go Outdated Show resolved Hide resolved
@CristhianF7 CristhianF7 changed the title feat: resource groups and domain endpoints feat: domain endpoints Dec 4, 2024
@CristhianF7 CristhianF7 changed the title feat: domain endpoints feat: azure domains endpoint Dec 4, 2024
@CristhianF7 CristhianF7 requested review from patrickdappollonio and removed request for patrickdappollonio December 4, 2024 23:14
@CristhianF7 CristhianF7 mentioned this pull request Dec 5, 2024
Merged
@CristhianF7 CristhianF7 merged commit b04a85f into main Dec 5, 2024
2 checks passed
@CristhianF7 CristhianF7 deleted the feat-azure-endpoints branch December 5, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickdappollonio patrickdappollonio patrickdappollonio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CristhianF7 @patrickdappollonio