util: fix incorrect comparison for resource.go#LessThanOrEqualComplet…

…ely (#2235) Signed-off-by: Tao Yang <[email protected]>
koordinator-sh · Oct 30, 2024 · 8661de2 · 8661de2
1 parent 78eafd4
commit 8661de2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/pkg/util/resource.go b/pkg/util/resource.go
@@ -266,7 +266,7 @@ func LessThanOrEqualCompletely(a corev1.ResourceList, b corev1.ResourceList) boo
 	result := true
 	delta := quotav1.Subtract(a, b)
 	for _, value := range delta {
-		if value.Value() > 0 {
+		if value.CmpInt64(0) > 0 {
 			result = false
 			break
 		}

diff --git a/pkg/util/resource_test.go b/pkg/util/resource_test.go
@@ -1099,6 +1099,16 @@ func TestLessThanOrEqualEnhanced(t *testing.T) {
 			},
 			expect: true,
 		},
+		{
+			name: "a < b, special case: deltaValue.Value() may overflow",
+			a: corev1.ResourceList{
+				corev1.ResourceMemory: resource.MustParse("1000Gi"),
+			},
+			b: corev1.ResourceList{
+				corev1.ResourceMemory: resource.MustParse("39999996Gi"),
+			},
+			expect: true,
+		},
 		{
 			name: "a > b",
 			a: corev1.ResourceList{