koordlet: remove useless stateInformer.impl StateInformer interface (#…

…2286) Signed-off-by: j4ckstraw <[email protected]>
koordinator-sh · Dec 2, 2024 · d06699e · d06699e
1 parent 13a7107
commit d06699e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 21 deletions.
diff --git a/pkg/koordlet/statesinformer/impl/callback_runner.go b/pkg/koordlet/statesinformer/impl/callback_runner.go
@@ -33,7 +33,7 @@ type UpdateCbCtx struct{}
 type callbackRunner struct {
 	callbackChans        map[statesinformer.RegisterType]chan UpdateCbCtx
 	stateUpdateCallbacks map[statesinformer.RegisterType][]updateCallback
-	statesInformer       StatesInformer
+	statesInformer       statesinformer.StatesInformer
 }
 
 func NewCallbackRunner() *callbackRunner {
@@ -53,7 +53,7 @@ func NewCallbackRunner() *callbackRunner {
 	return c
 }
 
-func (s *callbackRunner) Setup(i StatesInformer) {
+func (s *callbackRunner) Setup(i statesinformer.StatesInformer) {
 	s.statesInformer = i
 }
 

diff --git a/pkg/koordlet/statesinformer/impl/states_informer.go b/pkg/koordlet/statesinformer/impl/states_informer.go
@@ -45,23 +45,6 @@ const (
 	HTTPSScheme = "https"
 )
 
-type StatesInformer interface {
-	Run(stopCh <-chan struct{}) error
-	HasSynced() bool
-
-	GetNode() *corev1.Node
-	GetNodeSLO() *slov1alpha1.NodeSLO
-	GetNodeMetricSpec() *slov1alpha1.NodeMetricSpec
-
-	GetAllPods() []*statesinformer.PodMeta
-
-	GetNodeTopo() *topov1alpha1.NodeResourceTopology
-
-	GetVolumeName(pvcNamespace, pvcName string) string
-
-	RegisterCallbacks(objType statesinformer.RegisterType, name, description string, callbackFn statesinformer.UpdateCbFn)
-}
-
 type PluginName string
 
 type PluginOption struct {
@@ -102,11 +85,11 @@ type informerPlugin interface {
 	HasSynced() bool
 }
 
-var _ StatesInformer = &statesInformer{}
+var _ statesinformer.StatesInformer = &statesInformer{}
 
 // TODO merge all clients into one struct
 func NewStatesInformer(config *Config, kubeClient clientset.Interface, crdClient koordclientset.Interface, topologyClient topologyclientset.Interface,
-	metricsCache metriccache.MetricCache, nodeName string, schedulingClient schedv1alpha1.SchedulingV1alpha1Interface, predictorFactory prediction.PredictorFactory) StatesInformer {
+	metricsCache metriccache.MetricCache, nodeName string, schedulingClient schedv1alpha1.SchedulingV1alpha1Interface, predictorFactory prediction.PredictorFactory) statesinformer.StatesInformer {
 	opt := &PluginOption{
 		config:      config,
 		KubeClient:  kubeClient,