-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add more slo controllers e2e test #1688
ci: add more slo controllers e2e test #1688
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1688 +/- ##
==========================================
- Coverage 65.89% 65.89% -0.01%
==========================================
Files 384 384
Lines 41557 41557
==========================================
- Hits 27385 27382 -3
- Misses 12141 12143 +2
- Partials 2031 2032 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b5b507d
to
8f04433
Compare
45acca2
to
ccb8a73
Compare
Signed-off-by: saintube <[email protected]>
ccb8a73
to
4d7cfd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
77f919d
into
koordinator-sh:main
Ⅰ. Describe what this PR does
Add more E2E tests for slo-controller:
Revise the deploy scripts for koord-manager and koord-scheduler.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test