Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add more slo controllers e2e test #1688

Conversation

saintube
Copy link
Member

@saintube saintube commented Sep 29, 2023

Ⅰ. Describe what this PR does

Add more E2E tests for slo-controller:

  1. verify a batch pod can schedule the batch resources
  2. check the cpu normalization ratio updating

Revise the deploy scripts for koord-manager and koord-scheduler.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a317f1e) 65.89% compared to head (4d7cfd6) 65.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1688      +/-   ##
==========================================
- Coverage   65.89%   65.89%   -0.01%     
==========================================
  Files         384      384              
  Lines       41557    41557              
==========================================
- Hits        27385    27382       -3     
- Misses      12141    12143       +2     
- Partials     2031     2032       +1     
Flag Coverage Δ
unittests 65.89% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube saintube force-pushed the ci-add-slo-controller-e2e-tests branch 6 times, most recently from b5b507d to 8f04433 Compare September 29, 2023 09:57
@koordinator-bot koordinator-bot bot added size/XL and removed size/L labels Sep 29, 2023
pkg/webhook/elasticquota/mutating/webhooks.go Outdated Show resolved Hide resolved
test/e2e/framework/framework.go Outdated Show resolved Hide resolved
test/e2e/framework/test_context.go Outdated Show resolved Hide resolved
@saintube saintube force-pushed the ci-add-slo-controller-e2e-tests branch 6 times, most recently from 45acca2 to ccb8a73 Compare October 9, 2023 07:14
@saintube saintube force-pushed the ci-add-slo-controller-e2e-tests branch from ccb8a73 to 4d7cfd6 Compare October 9, 2023 08:06
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 77f919d into koordinator-sh:main Oct 9, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants