-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-manager: enhance batch resource configuration and updating #1703
koord-manager: enhance batch resource configuration and updating #1703
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1703 +/- ##
==========================================
+ Coverage 65.91% 65.93% +0.01%
==========================================
Files 385 385
Lines 41639 41766 +127
==========================================
+ Hits 27447 27539 +92
- Misses 12155 12186 +31
- Partials 2037 2041 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
df39afe
to
8726ac4
Compare
8726ac4
to
235bc6b
Compare
Explain when you need to use request instead of usage? |
235bc6b
to
24f36f5
Compare
Code comments are added for different calculating policies. |
/lgtm |
/approve |
Signed-off-by: saintube <[email protected]>
24f36f5
to
6e4c7e8
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes, zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
koord-manager: enhance batch resource configuration and updating:
cpuCalculatePolicy
in the ColocationStrategy. Enable calculatingbatch-cpu
according to high-priority pods' maximal of requests and usages. The default policy isusage
, which allows the low-priority pods to reclaim the resources requested but unused by the high-priority pods. The new policymaxUsageAndRequest
is helpful when the cpu resources are not strongly expected to be overcommitted between different priority bands, where neither used resources nor requested resources can be allocatable to the low-priority pods.Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test