Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: reservation senses node affinity #1713

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Oct 18, 2023

Ⅰ. Describe what this PR does

Reservation plugin senses NodeAffinity and reduces the amount of calculation. For example, DaemonSet Pod is only scheduled to one node, so we only need to process the Reservation of one node.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (cf81f9c) 65.89% compared to head (5fd576f) 65.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1713      +/-   ##
==========================================
+ Coverage   65.89%   65.92%   +0.02%     
==========================================
  Files         385      385              
  Lines       41639    41684      +45     
==========================================
+ Hits        27438    27479      +41     
- Misses      12160    12167       +7     
+ Partials     2041     2038       -3     
Flag Coverage Δ
unittests 65.92% <75.47%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/scheduler/frameworkext/controllers.go 32.14% <0.00%> (ø)
pkg/scheduler/plugins/reservation/transformer.go 63.08% <76.92%> (+4.19%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hormes
Copy link
Member

hormes commented Oct 18, 2023

/lgtm

Copy link
Contributor

@buptcozy buptcozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@buptcozy
Copy link
Contributor

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: buptcozy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit a3ba941 into koordinator-sh:main Oct 18, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants