Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: reservation transformer ends early with reservation affinity #1717

Conversation

eahydra
Copy link
Member

@eahydra eahydra commented Oct 19, 2023

Ⅰ. Describe what this PR does

The Pod declares a ReservationAffinity, which means that the Pod must reuse the Reservation resources, but there are no matching Reservations, which means that the node itself does not need to be processed. We can end early to avoid meaningless operations.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@eahydra
Copy link
Member Author

eahydra commented Oct 19, 2023

/cc @hormes @FillZpp @ZiMengSheng PTAL

@koordinator-bot
Copy link

@eahydra: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only koordinator-sh members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @hormes @FillZpp @ZiMengSheng PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eahydra eahydra requested a review from jasonliu747 October 19, 2023 08:13
@eahydra eahydra changed the title scheduler: reservation transformer end early with reservation affinity scheduler: reservation transformer ends early with reservation affinity Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (3270ae7) 65.92% compared to head (ab90583) 65.94%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1717      +/-   ##
==========================================
+ Coverage   65.92%   65.94%   +0.02%     
==========================================
  Files         385      385              
  Lines       41702    41832     +130     
==========================================
+ Hits        27490    27587      +97     
- Misses      12174    12206      +32     
- Partials     2038     2039       +1     
Flag Coverage Δ
unittests 65.94% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/scheduler/plugins/reservation/transformer.go 64.45% <0.00%> (+1.36%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hormes
Copy link
Member

hormes commented Oct 19, 2023

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 4b4ba9a into koordinator-sh:main Oct 19, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants