Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: fix missing update quota when pod is in DeletedFinalStateUnknown state #1737

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

qinfustu
Copy link
Contributor

Ⅰ. Describe what this PR does

koord-scheduler: fix sometimes the quota is not updated after the pod is deleted.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f197bbc) 66.03% compared to head (53bcb4d) 66.09%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1737      +/-   ##
==========================================
+ Coverage   66.03%   66.09%   +0.06%     
==========================================
  Files         388      388              
  Lines       42314    42379      +65     
==========================================
+ Hits        27940    28009      +69     
+ Misses      12303    12299       -4     
  Partials     2071     2071              
Flag Coverage Δ
unittests 66.09% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eahydra eahydra changed the title koord-scheduler: fix sometimes the quota is not updated after the pod is deleted scheduler: fix missing update quota if pod is deleted Nov 13, 2023
@eahydra eahydra changed the title scheduler: fix missing update quota if pod is deleted scheduler: fix missing update quota when pod is Pod is in DeletedFinalStateUnknown state Nov 13, 2023
@eahydra eahydra changed the title scheduler: fix missing update quota when pod is Pod is in DeletedFinalStateUnknown state scheduler: fix missing update quota when pod is in DeletedFinalStateUnknown state Nov 13, 2023
Copy link
Member

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eahydra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 08b6e89 into koordinator-sh:main Nov 20, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants