Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-manager: improve batch resource calculation #1751

Conversation

saintube
Copy link
Member

@saintube saintube commented Nov 22, 2023

Ⅰ. Describe what this PR does

  • apis: Add new fields Priority and QoS onto the PodMetricInfo.
  • koord-manager: Improve the calculation of BatchResource.
  • koordlet: Revise the calculation of the non-BE allocatable cpu.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (cf2b50f) 66.12% compared to head (20040bd) 66.07%.
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/koordlet/qosmanager/helpers/calculator.go 53.70% 20 Missing and 5 partials ⚠️
.../koordlet/statesinformer/impl/states_nodemetric.go 71.42% 4 Missing ⚠️
...oller/noderesource/plugins/batchresource/plugin.go 94.33% 2 Missing and 1 partial ⚠️
pkg/koordlet/prediction/peak_predictor.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1751      +/-   ##
==========================================
- Coverage   66.12%   66.07%   -0.05%     
==========================================
  Files         388      389       +1     
  Lines       42438    42467      +29     
==========================================
  Hits        28061    28061              
- Misses      12309    12327      +18     
- Partials     2068     2079      +11     
Flag Coverage Δ
unittests 66.07% <76.25%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube saintube force-pushed the improve-batch-resource-estimation branch from f216523 to 20040bd Compare November 23, 2023 01:43
@zwzhang0107
Copy link
Contributor

/lgtm
/approve

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, jasonliu747, zwzhang0107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit e410b79 into koordinator-sh:main Nov 28, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants