-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: verify quota according to resource dimensions required by pod #1753
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1753 +/- ##
==========================================
- Coverage 66.11% 66.10% -0.02%
==========================================
Files 388 388
Lines 42425 42475 +50
==========================================
+ Hits 28048 28076 +28
- Misses 12305 12324 +19
- Partials 2072 2075 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: fu_qin <[email protected]>
@qinfustu This PR has been very clear. Nice job! And it is recommended to add some specific UT cases. This scenario is indeed easily overlooked. |
I am currently on paternity leave. Please help me follow up on PR merger, @eahydra. Thx~ |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eahydra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
fix the resources required by the pod in the quota are sufficient but the pod cannot be scheduled.
Ⅱ. Does this pull request fix one issue?
The resources required by the pod in the quota are sufficient but the pod cannot be scheduled.
e.q.
quota info
pod info
At this time, the pod will not be scheduled due to insufficient quota resources(nvidia.com/gpu: runtime < used). In fact, the cpu and memory required by the pod are sufficient.
There are scenarios where runtime < used appears:
App version: 1.20
Kubernetes version (use kubectl version): 1.19
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test