Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: supply rdma devices #2276

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

ZiMengSheng
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@ZiMengSheng ZiMengSheng changed the title Rdma report koordlet: supply rdma devices Nov 20, 2024
@ZiMengSheng ZiMengSheng force-pushed the rdma_report branch 9 times, most recently from fe48598 to 7c64451 Compare December 4, 2024 09:06
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 35.24590% with 79 lines in your changes missing coverage. Please review.

Project coverage is 65.98%. Comparing base (b36d230) to head (c1168ab).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/koordlet/util/system/sriov.go 0.00% 49 Missing ⚠️
...oordlet/statesinformer/impl/states_device_linux.go 66.66% 18 Missing and 3 partials ⚠️
.../metricsadvisor/devices/gpu/collector_gpu_linux.go 0.00% 7 Missing ⚠️
pkg/koordlet/util/device.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2276      +/-   ##
==========================================
- Coverage   66.07%   65.98%   -0.10%     
==========================================
  Files         454      455       +1     
  Lines       53451    53607     +156     
==========================================
+ Hits        35318    35371      +53     
- Misses      15593    15689      +96     
- Partials     2540     2547       +7     
Flag Coverage Δ
unittests 65.98% <35.24%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZiMengSheng
Copy link
Contributor Author

/lgtm

Signed-off-by: wangjianyu.wjy <[email protected]>
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saintube saintube added the lgtm label Dec 5, 2024
@koordinator-bot koordinator-bot bot merged commit 7c94119 into koordinator-sh:main Dec 5, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants