-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: support priority+qos apis. #2280
base: main
Are you sure you want to change the base?
api: support priority+qos apis. #2280
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2280 +/- ##
==========================================
- Coverage 66.06% 66.04% -0.02%
==========================================
Files 454 458 +4
Lines 53405 53921 +516
==========================================
+ Hits 35281 35612 +331
- Misses 15586 15751 +165
- Partials 2538 2558 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
7863c2a
to
b102fe6
Compare
/assign @saintube |
apis/extension/priority_qos.go
Outdated
// SYSTEM | ||
// koord-prod: LS LSE LSR | ||
// koord-mid: LS BE | ||
// koord-batch: BE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Batch + LS, Free + LS are acceptable in some scenarios.
e.g. Apps allocate Batch resources to co-locate with the Prod pods, but they'd rather get evicted than suppressed.
For now, it is suggested that check the combinations of the priority classes and QoS classes loosely.
Signed-off-by: wangyang60 <[email protected]>
For priority and qos combinations, we only consider the following valid combinations.
Because koord-system is considered as koord-prod, qosNone is considered as LS, and qosSystem is handled separately. Related PR #2270 |
b102fe6
to
e83cf70
Compare
Ⅰ. Describe what this PR does
In order to implement priorityQosFilter, it is necessary to implement the priorityQosClass API.
Ⅱ. Does this pull request fix one issue?
part of #2161
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test