Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: support priority+qos apis. #2280

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tan90github
Copy link
Contributor

Ⅰ. Describe what this PR does

In order to implement priorityQosFilter, it is necessary to implement the priorityQosClass API.

Ⅱ. Does this pull request fix one issue?

part of #2161

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.04%. Comparing base (ceff9cd) to head (e83cf70).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2280      +/-   ##
==========================================
- Coverage   66.06%   66.04%   -0.02%     
==========================================
  Files         454      458       +4     
  Lines       53405    53921     +516     
==========================================
+ Hits        35281    35612     +331     
- Misses      15586    15751     +165     
- Partials     2538     2558      +20     
Flag Coverage Δ
unittests 66.04% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tan90github tan90github force-pushed the feature/priority-qos-api branch from 7863c2a to b102fe6 Compare November 27, 2024 04:07
@songtao98
Copy link
Contributor

/assign @saintube

// SYSTEM
// koord-prod: LS LSE LSR
// koord-mid: LS BE
// koord-batch: BE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Batch + LS, Free + LS are acceptable in some scenarios.
e.g. Apps allocate Batch resources to co-locate with the Prod pods, but they'd rather get evicted than suppressed.

For now, it is suggested that check the combinations of the priority classes and QoS classes loosely.

@tan90github
Copy link
Contributor Author

tan90github commented Dec 30, 2024

For priority and qos combinations, we only consider the following valid combinations.

QoS\Priority koord-prod koord-mid koord-batch koord-free
LSE
LSR
LS
BE

Because koord-system is considered as koord-prod, qosNone is considered as LS, and qosSystem is handled separately.

Related PR #2270

@tan90github tan90github force-pushed the feature/priority-qos-api branch from b102fe6 to e83cf70 Compare December 30, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants