Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: fix reconciler description mismatch. #2282

Merged

Conversation

tan90github
Copy link
Contributor

Ⅰ. Describe what this PR does

Different conditions within the same reconciler correspond to different descriptions, similar to fn, but the current description has not been updated according to the condition; this PR fixes that issue.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@tan90github
Copy link
Contributor Author

PTAL @saintube thx.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 35.71429% with 27 lines in your changes missing coverage. Please review.

Project coverage is 66.05%. Comparing base (6fa0388) to head (1c3bb44).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
pkg/koordlet/runtimehooks/reconciler/reconciler.go 35.71% 26 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2282      +/-   ##
==========================================
+ Coverage   66.04%   66.05%   +0.01%     
==========================================
  Files         454      454              
  Lines       53413    53449      +36     
==========================================
+ Hits        35274    35307      +33     
  Misses      15599    15599              
- Partials     2540     2543       +3     
Flag Coverage Δ
unittests 66.05% <35.71%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@koordinator-bot koordinator-bot bot merged commit 50cfd34 into koordinator-sh:main Dec 5, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants